forked from cloudfoundry/stratos
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge upstream #378
Merged
Merged
Merge upstream #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
richard-cox
commented
May 18, 2020
- contains entity/entities access improvements
Allow e2e test logging to be controlled by label on PR
noticed that in this commit which updates the stratos console uaa configuration to be simpler and leverage "uaa.endpoint" that the README was using an example referencing "uaa.url" (which I don't think is a param reference? could be wrong?) and still including uaa.port, uaa.host, etc., though it appears that was all replaced by `uaa.endpoint` no rush; would appreciate if someone double-checked this, I didn't completely confirm or test this, to be honest. I'll look more into it this evening after work. apologies if I'm dead wrong. thanks for the time
…console - bumps doc to point to 3.2.0 - fixes the `helm search` command to `helm repo search` (at least that's what it is for helm3?)
) * Fix exception SidePanelService: container already set on browser back to & return from login - hit browser back button until login screen temporarily hit - ERROR Error: SidePanelService: container already set thrown - This was due to DashboardBaseComponent initialising the side panel twice, once per nav from login pages - fix is to ensure the panel service only lives in the DashboardBaseComponent rather than whole app * Ensure initialRequest process is only set up once * Fix issue where additional pages are refretched after return from log - nav to marketplace. marketplace should contain over 100 services - hit browser back to temporarily go to login page and back - non-first pages were refetched, with one causing a 'write to protected obj' error ``` entity-request-pipeline.ts:94 TypeError: Cannot assign to read only property 'cfGuid' of object '[object Object]' at globalSuccessfulRequestDataMapper (cf-entity-generator.ts:173) at map-multi-endpoint.pipes.ts:37 at Array.reduce (<anonymous>) at map-multi-endpoint.pipes.ts:35 at Array.reduce (<anonymous>) at getEntities (map-multi-endpoint.pipes.ts:31) at map-multi-endpoint.pipes.ts:102 at Array.map (<anonymous>) at mapMultiEndpointResponses (map-multi-endpoint.pipes.ts:101) at MapSubscriber.project (entity-pagination-request-pipeline.ts:134) ``` * Fix `+` icon in service summary page * Fix side panel * Revert "Fix `+` icon in service summary page" This reverts commit e5d3916.
Angular 9 migration
Additional changes to support Cloud Foundry code to correct package
Wrap check for missing env var for forked CI
update kubernetes deploy doc to reference uaa.endpoint
Fix misaligned user button
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
==========================================
+ Coverage 59.35% 59.37% +0.02%
==========================================
Files 1049 1046 -3
Lines 33499 33076 -423
Branches 4604 4636 +32
==========================================
- Hits 19883 19640 -243
+ Misses 13616 13436 -180 |
# Conflicts: # package-lock.json # protractor.conf.js
``` require(...).create is not a function TypeError: require(...).create is not a function at Object.<anonymous> (/home/travis/build/SUSE/stratos/node_modules/istanbul/lib/report/html.js:7:40) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.